Skip to content

ci/tmt: pin ubuntu to last working version - #2351

Merged
angelcerveraroldan merged 1 commit into
coreos:mainfrom
angelcerveraroldan:tmt-ubuntu
Oct 27, 2026
Merged

ci/tmt: pin ubuntu to last working version#2351
angelcerveraroldan merged 1 commit into
coreos:mainfrom
angelcerveraroldan:tmt-ubuntu

Conversation

@angelcerveraroldan

@angelcerveraroldan angelcerveraroldan commented Oct 27, 2026

Copy link
Copy Markdown
Member

We are seeing issues with ubuntu-latest when trying to shut down / remove containers, causing CI to fail.

For now we can stick to using the last working version.

@angelcerveraroldan
ci/tmt: pin ubuntu to last working version
b47f3c8 
We are seeing issues with ubuntu-latest when trying to shut down /
remove containers, causing CI to fail.

For now we can stick to using the last working version.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 3f0c1b9 and b47f3c8.

Files selected for processing: 1
  • .github/workflows/tmt-tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Recent review details
Context from checks skipped due to timeout: 10
  • GitHub Check: CodeRabbit
  • GitHub Check: Build butane container image
  • GitHub Check: Build container image
  • GitHub Check: Test ignition-validate (1.26.x, macos-latest)
  • GitHub Check: Test ignition-validate (1.26.x, windows-latest)
  • GitHub Check: Test (1.26.x)
  • GitHub Check: Check binary size
  • GitHub Check: Test (1.25.x)
  • GitHub Check: Shellcheck
  • GitHub Check: tmt-tests
CI failures not shown inline: 2

GitHub Actions: Release notes / 0_Require release note.txt: ci/tmt: pin ubuntu to last working version

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mif [ -n "skip-notes" ]; then�[0m
 �[36;1m    # Don't trust the label list in the event metadata, since runs�[0m
 �[36;1m    # can be scheduled out of order and the list might be stale.�[0m
 �[36;1m    label=$(curl --no-progress-meter \�[0m
 �[36;1m        -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m        -H "Authorization: token ***" \�[0m
 �[36;1m        "https://api.github.com/repos/coreos/ignition/pulls/2351" |�[0m
 �[36;1m        jq '.labels[] | select(.name == "skip-notes")')�[0m
 �[36;1m    if [ -n "${label}" ]; then�[0m
 �[36;1m        echo "PR has skip-notes label; skipping"�[0m
 �[36;1m        exit 0�[0m
 �[36;1m    fi�[0m
 �[36;1mfi�[0m
 �[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
 �[36;1m    -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m    -H "Authorization: token ***" \�[0m
 �[36;1m    "https://api.github.com/repos/coreos/ignition/compare/3f0c1b905fc0dc4ed24554dfe4372ffe44c20b78...b47f3c85b7d7c3f2e64733eaf81230fc00938ac8" |�[0m
 �[36;1m    jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
 �[36;1mif [ -z "${diffinfo}" ]; then�[0m
 �[36;1m    echo "Found no changes to docs/release-notes.md."�[0m
 �[36;1m    if [ -n "skip-notes" ]; then�[0m
 �[36;1m        echo "To ignore, add skip-notes label to PR."�[0m
 �[36;1m    fi�[0m
 �[36;1m    exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "Found change to docs/release-notes.md."�[0m
 shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
 ##[endgroup]
 Found no changes to docs/release-notes.md.
 To ignore, add skip-notes label to PR.
 ##[error]Process completed with exit code 1.

GitHub Actions: Release notes / Require release note: ci/tmt: pin ubuntu to last working version

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mif [ -n "skip-notes" ]; then�[0m
 �[36;1m    # Don't trust the label list in the event metadata, since runs�[0m
 �[36;1m    # can be scheduled out of order and the list might be stale.�[0m
 �[36;1m    label=$(curl --no-progress-meter \�[0m
 �[36;1m        -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m        -H "Authorization: token ***" \�[0m
 �[36;1m        "https://api.github.com/repos/coreos/ignition/pulls/2351" |�[0m
 �[36;1m        jq '.labels[] | select(.name == "skip-notes")')�[0m
 �[36;1m    if [ -n "${label}" ]; then�[0m
 �[36;1m        echo "PR has skip-notes label; skipping"�[0m
 �[36;1m        exit 0�[0m
 �[36;1m    fi�[0m
 �[36;1mfi�[0m
 �[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
 �[36;1m    -H "Accept: application/vnd.github+json" \�[0m
 �[36;1m    -H "Authorization: token ***" \�[0m
 �[36;1m    "https://api.github.com/repos/coreos/ignition/compare/3f0c1b905fc0dc4ed24554dfe4372ffe44c20b78...b47f3c85b7d7c3f2e64733eaf81230fc00938ac8" |�[0m
 �[36;1m    jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
 �[36;1mif [ -z "${diffinfo}" ]; then�[0m
 �[36;1m    echo "Found no changes to docs/release-notes.md."�[0m
 �[36;1m    if [ -n "skip-notes" ]; then�[0m
 �[36;1m        echo "To ignore, add skip-notes label to PR."�[0m
 �[36;1m    fi�[0m
 �[36;1m    exit 1�[0m
 �[36;1mfi�[0m
 �[36;1mecho "Found change to docs/release-notes.md."�[0m
 shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
 ##[endgroup]
 Found no changes to docs/release-notes.md.
 To ignore, add skip-notes label to PR.
 ##[error]Process completed with exit code 1.
Additional context used
zizmor (1.30.1)
.github/workflows/tmt-tests.yml

[warning] 31-81: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

Additional comments: 1
.github/workflows/tmt-tests.yml: 1

32-32: LGTM!

Walkthrough

The tmt-tests workflow job now runs on ubuntu-24.04 instead of ubuntu-latest.

Changes: tmt-tests runner

Layer / File(s) Summary
Update the job runner
.github/workflows/tmt-tests.yml		 The tmt-tests job now uses the ubuntu-24.04 runner.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: tlbueno

Merge Risk: Minimal · up to b47f3

The workflow change is narrowly scoped and does not introduce a concrete merge-blocking risk.

Pre-merge checks: Passed 6
Check name Status Explanation
Description check Passed The description explains that ubuntu-latest causes container cleanup failures and that the workflow will use the last working Ubuntu version.
Title check Passed The title uses the required subsystem: lowercase description format, uses imperative mood, and accurately describes pinning Ubuntu for TMT CI.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Commit Message Convention Passed The PR has one non-merge commit: ci/tmt: pin ubuntu to last working version. It uses a valid subsystem, starts the description with the lowercase imperative verb pin, and has no trailing period.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@angelcerveraroldan

angelcerveraroldan commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

This is the same issue as seen in coreos/bootupd#1179, probably we will want a better long term solution but this unblocks others PRs.

@angelcerveraroldan angelcerveraroldan added the skip-notes This PR does not need release notes label Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026

Copy link
Copy Markdown

Binary size report (bin/amd64/ignition)

Size
Base (main) 33MiB
PR (#2351) 33MiB
Delta +0B (0.00%)

yasminvalim
yasminvalim approved these changes Oct 27, 2026
View reviewed changes

@yasminvalim yasminvalim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlbueno
tlbueno self-requested a review October 27, 2026 17:11
tlbueno
tlbueno approved these changes Oct 27, 2026
View reviewed changes

@tlbueno tlbueno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@angelcerveraroldan
angelcerveraroldan merged commit 66e7c52 into coreos:main Oct 27, 2026
15 of 17 checks passed
@angelcerveraroldan angelcerveraroldan mentioned this pull request Oct 28, 2026
Merged
@drkrillo drkrillo mentioned this pull request Oct 29, 2026
Open
2 of 22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlbueno tlbueno tlbueno approved these changes
@yasminvalim yasminvalim yasminvalim approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

skip-notes This PR does not need release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angelcerveraroldan @tlbueno @yasminvalim